Repository navigation
Fall back to motherboard serial in run reporting - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run summaries now resolve serialNumber from Win32_BIOS, then Win32_BaseBoard when BIOS is blank,
Default String, orSystem Serial Number. This replaces the independent registry lookup so reporting uses the firmware serial sources used for enrollment.Values are trimmed, placeholder checks ignore case, and a valid BIOS serial avoids the motherboard query. Lookup failures remain best-effort and two unusable sources retain the existing empty serial representation. Adds System.Management 10.0.12 for WMI access.
Validation: Windows CI passed both x64 and ARM64 CLI, GUI and MSI builds; all 225 core unit tests passed on x64. The 15 focused resolver tests also pass on macOS (.NET 10). Real firmware validation and a signed release remain deployment gates.
Risk: medium — changes reported hardware identity on devices with invalid BIOS serials and adds a WMI dependency; no release or deployment in this PR.
Closes #69